-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pr_check.sh script to not verify the year #3063
Updated pr_check.sh script to not verify the year #3063
Conversation
Please notice that lately we changed our policy |
@Nir-Az, No. This regex will fail in that case. |
Then please adjust |
|
@Nir-Az, for now, I will update such that both "2023" and "2015-2024" year formats will work. In future, we are also thinking of updating the script such that it will perform the check only on the modified files of that particular PR. Also, to check whether the given year is current year. |
@Arun-Prasad-V thanks for the fix. |
@Nir-Az, I have tested it locally.
It just checks whether there are 4 numeric digits in the YEAR location or not. It doesn't validate whether the year is current year or not. User must provide valid 4-digit year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.